Make seed part of config and pass into recheck data#482
Merged
Conversation
moodmosaic
requested changes
Mar 25, 2026
Member
moodmosaic
left a comment
moodmosaic
left a comment
There was a problem hiding this comment.
Thank you for the PR!
The core feature is a good addition, but the default should be RandomSeed to preserve existing behavior. The withSeed API lets users opt into determinism explicitly, which is the right trade-off for a property testing library.
moodmosaic
approved these changes
May 10, 2026
Member
moodmosaic
left a comment
moodmosaic
left a comment
There was a problem hiding this comment.
Thank you, @njlr 👍 This is in good shape to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SeedConfigfor defining starting seed configurationIPropertyConfigwith aSeedConfigSeedConfigin aIPropertyConfigSeedConfigto set initialRecheckDatainreportWithPropertyConfig.defaultsRelates to #450